[Addon] velaux allow a custom ingress class name #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oana Schipor <[email protected]>
wonderflow
reviewed
Dec 5, 2023
addons/velaux/resources/server.cue
Outdated
| @@ -23,7 +23,7 @@ _nginxTrait: *[ | |||
| http: { | |||
| "/": 8000 | |||
| } | |||
| class: "nginx" | |||
| class: parameter["ingressClass"] | |||
There was a problem hiding this comment.
maybe you can reuse the gatewayDriver field.
There was a problem hiding this comment.
Noted, updated to use gatewayDriver and works on my cluser. The e2e test however is timing out, seeing why
There was a problem hiding this comment.
Tests are failing because the version of the addon is also used for the image tag, do you prefer creating a new tag v1.9.4 or parameterising the image tag and allow for addons upgrades independently from velaux
There was a problem hiding this comment.
@charlie0129 what do you think. I get is nice for the tag/version of addon to map but in reality there can be addon changes with not image release
Signed-off-by: Oana Schipor <[email protected]>
Signed-off-by: Oana Schipor <[email protected]>
Signed-off-by: Oana Schipor <[email protected]>
Signed-off-by: Oana Schipor <[email protected]>
oanasc
changed the title
wonderflow
reviewed
Nov 29, 2024
| @@ -15,15 +15,15 @@ enableImpersonation: *[ if parameter["enableImpersonation"] { | |||
| }] | [] | |||
|
|
|||
| _nginxTrait: *[ | |||
| if parameter["domain"] != _|_ && parameter["gatewayDriver"] == "nginx" { | |||
| if parameter["domain"] != _|_ && parameter["gatewayDriver"] != "traefik" { | |||
There was a problem hiding this comment.
why != traefik go the logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes ##739
How has this code been tested?
Enabled the modified addon locally and ensured I can specify the gatewayDriver with a custom name and that is correctly used in the ingressClass annotation the ingress works.
Checklist
I have:
[Addon],[example]or[Doc]).versioninmetadata.yamlto generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml.README.md.